-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin ENV Update #316
Admin ENV Update #316
Conversation
Afternoon @Lomilar, this is the minor update to allow for an admin signature based on their email -- lmk if there are any adjustments needed etc. Thanks! |
This can be easily broken by somehow setting my email address to ".com" You'll want exact matching with a comma separated list of email addresses. |
That's how it works yeah, the
making it an array inclusion check and not a string inclusion check etc. |
Updated the names to be less confusing with the const names vs. env names. |
Got it. |
Quality Gate passedIssues Measures |
#issue - There does not currently seem to be a way of specifying an admin user through environment variables.
This update will allow for two optional environment variables:
AUTH_ALLOW_ENV_ADMINS
AUTH_ENV_ADMIN_EMAILS
which will add the admin signature to their sheets when the corresponding users log in.
Security Impact: An improperly configured OIDC system may allow users to manually set their email address to that of the configured administrator.
Presumptive Impact: This will enable the use of an admin account for the Platform One deployment of CaSS, allowing for several PII concerns to be mitigated through the on-request removal of personal information.